zacharymorn commented on code in PR #240:
URL: https://github.com/apache/lucene/pull/240#discussion_r1387436327
##########
lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/SearchWithCollectorTask.java:
##########
@@ -45,20 +43,6 @@ public boolean withCollector() {
return true;
}
- @Override
- protected Collector createCollector() throws Exception {
Review Comment:
Hmm after some more thought about this, I feel maybe I should revert this
change here for now given the task tests not just the `TopScoreDocCollector`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
