mikemccand commented on code in PR #12738: URL: https://github.com/apache/lucene/pull/12738#discussion_r1382378735
########## lucene/core/src/java/org/apache/lucene/util/fst/ByteBlockPoolReverseBytesReader.java: ########## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.util.fst; + +import java.io.IOException; +import org.apache.lucene.util.ByteBlockPool; + +/** Reads in reverse from a ByteBlockPool. */ +final class ByteBlockPoolReverseBytesReader extends FST.BytesReader { + + private final ByteBlockPool buf; + // the difference between the FST node address and the hash table copied node address + private long posDelta; + private long pos; + + public ByteBlockPoolReverseBytesReader(ByteBlockPool buf) { + this.buf = buf; + } + + @Override + public byte readByte() { + return buf.readByte(pos--); + } + + @Override + public void readBytes(byte[] b, int offset, int len) { + for (int i = 0; i < len; i++) { + b[offset + i] = buf.readByte(pos--); + } + } + + @Override + public void skipBytes(long numBytes) throws IOException { + pos -= numBytes; + } + + @Override + public long getPosition() { + return pos + posDelta; + } + + @Override + public void setPosition(long pos) { + this.pos = pos - posDelta; + } + + @Override + public boolean reversed() { Review Comment: I'll open a spinoff issue for this -- it seems at quick glance to be dead/pointless code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
