mikemccand commented on code in PR #12738:
URL: https://github.com/apache/lucene/pull/12738#discussion_r1382379017
##########
lucene/core/src/java/org/apache/lucene/util/ByteBlockPool.java:
##########
@@ -38,6 +38,8 @@ public final class ByteBlockPool implements Accountable {
/** Abstract class for allocating and freeing byte blocks. */
public abstract static class Allocator {
+ // TODO: ByteBlockPool assume the blockSize is always {@link
BYTE_BLOCK_SIZE}, but this class
+ // allow arbitrary value of blockSize. We should make them consistent.
protected final int blockSize;
Review Comment:
Hmm do we have any `if` or `assert` that confirms `Allocator`'s `blockSize`
== `ByteBlockPool.BYTE_BLOCK_SIZE` when passed to `ByteBlockPool`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
