mikemccand commented on PR #12738:
URL: https://github.com/apache/lucene/pull/12738#issuecomment-1792293648
Thanks @dungba88!
I confirmed that `IndexToFST` now works again, and, when given "up to" `inf`
RAM to use, it produces the same sized minimal `fst.bin` as main at `367244208
bytes`.
It's a bit slower than `main`, but that's to be expected and I think OK. We
can optimize later ... being able to fully cap RAM usage, nomatter how big an
FST you produce, is worth this tradeoff. (Note: we still need to fix FST
writing to spool to disk to achieve RAM capping, the other PR @dungba88 is
tackling -- thank you!).
`main`:
```
saved FST to "fst.bin": 367244208 bytes; 47.758 sec
saved FST to "fst.bin": 367244208 bytes; 48.134 sec
```
This PR:
```
saved FST to "fst.bin": 367244208 bytes; 54.765 sec
saved FST to "fst.bin": 367244208 bytes; 58.616 sec
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
