rmuir commented on PR #12753: URL: https://github.com/apache/lucene/pull/12753#issuecomment-1792647332
> 2\. we use deprecated java.util Locale constructor - usage should likely be replaced with Locale:of > Locale:of factories are added in Java 19, so this kinda the change to the version bump. Maybe evaluate using Local.Builder Or just consider `forLanguageTag` which has been around forever (java 8?). AFAIK Locale.of etc are just sugar over that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
