zacharymorn commented on PR #12194: URL: https://github.com/apache/lucene/pull/12194#issuecomment-1585394121
Thanks @jpountz for the review! > It'd be good to understand if we can reduce the overhead for the case when the optimization doesn't kick in, as I'd expect this case to remain the most common one. Yes indeed. Aside from further optimizing the logic itself, I have been thinking about two potential approaches, but they each have some pros / cons: 1. Add a flag for application to control whether this new optimization / API should be used or not. 2. Automatically pause the use of this optimization and re-check after certain number of docs if the code detects continuous small skips between API calls. What do you think about these approaches? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
