zacharymorn commented on code in PR #12194:
URL: https://github.com/apache/lucene/pull/12194#discussion_r1148629792
##########
lucene/core/src/java/org/apache/lucene/search/DocIdSetIterator.java:
##########
@@ -82,6 +82,11 @@ public int advance(int target) throws IOException {
return doc;
}
+ @Override
Review Comment:
Good catch. I have overridden `range` and also `empty` now.
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90PostingsReader.java:
##########
@@ -479,6 +481,36 @@ private void refillDocs() throws IOException {
assert docBuffer[BLOCK_SIZE] == NO_MORE_DOCS;
}
+ @Override
+ public int peekNextNonMatchingDocID() throws IOException {
Review Comment:
Yup indeed! I was planning to do that after enhancing assertions /
`CheckIndex` for existing changes. I have added that to all 5 of them now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
