mayya-sharipova commented on code in PR #12314:
URL: https://github.com/apache/lucene/pull/12314#discussion_r1206004550
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene95/Lucene95HnswVectorsWriter.java:
##########
@@ -762,13 +776,18 @@ private void writeMeta(
meta.writeVInt(DIRECT_MONOTONIC_BLOCK_SHIFT);
// dense case and empty case do not need to store ordToMap mapping
final DirectMonotonicWriter ordToDocWriter =
- DirectMonotonicWriter.getInstance(meta, vectorData, count,
DIRECT_MONOTONIC_BLOCK_SHIFT);
+ DirectMonotonicWriter.getInstance(meta, vectorData, vectorsCount,
DIRECT_MONOTONIC_BLOCK_SHIFT);
DocIdSetIterator iterator = docsWithField.iterator();
+ int[] valuesPerDocument = docsWithField.getValuesPerDocument();
Review Comment:
This seems to use a lot of memory, may be for inspiration, we can use how
`SortedSetDocValuesWriter` class writes multiple values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
