mayya-sharipova commented on code in PR #12314: URL: https://github.com/apache/lucene/pull/12314#discussion_r1205995223
########## lucene/core/src/java/org/apache/lucene/index/DocsWithFieldSet.java: ########## @@ -22,6 +22,8 @@ import org.apache.lucene.util.FixedBitSet; import org.apache.lucene.util.RamUsageEstimator; +import java.util.Stack; Review Comment: I think we should keep this class unchanged; it is used in other places besides vectors and is only about documents. For keeping track of the number of values in docs, may be we can use another data-structure (`PackedLongValues.Builder`, similar how `SortedSetDocValuesWriter` does it)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
