mayya-sharipova commented on code in PR #12314:
URL: https://github.com/apache/lucene/pull/12314#discussion_r1206003463
##########
lucene/core/src/java/org/apache/lucene/index/DocsWithFieldSet.java:
##########
@@ -32,8 +34,14 @@ public final class DocsWithFieldSet extends DocIdSet {
RamUsageEstimator.shallowSizeOfInstance(DocsWithFieldSet.class);
private FixedBitSet set;
- private int cardinality = 0;
- private int lastDocId = -1;
+ private int docsCount = 0;
+ private int lastDocId = 0; // at a certain point in time this was changed to
0? why?
+
+ private Stack<Integer> valuesPerDocuments;
+ private int currentDocVectorsCount;
+ private int vectorsCount;
+
+ private boolean multiValued = false;
Review Comment:
It is also strange to have this `multiValued` field, we probably should just
multi values by presence/absence of another data structure that keeps number of
values in docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
