uschindler commented on code in PR #12311:
URL: https://github.com/apache/lucene/pull/12311#discussion_r1199008182
##########
gradle/testing/defaults-tests.gradle:
##########
@@ -122,7 +122,7 @@ allprojects {
// Lucene needs to optional modules at runtime, which we want to enforce
for testing
// (if the runner JVM does not support them, it will fail tests):
- jvmArgs '--add-modules', 'jdk.unsupported,jdk.management'
+ jvmArgs '--add-modules',
'jdk.unsupported,jdk.management,jdk.incubator.vector'
Review Comment:
I don't think we need to explicitly test both. If the build runs with java
17 and no runtime of 20 given it uses legacy code.
The same us true for mmapdir. There it is tested by Jenkins based on the
used jfk version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
