uschindler commented on PR #12311: URL: https://github.com/apache/lucene/pull/12311#issuecomment-1553665376
> > I'd prefer to have separate apijars, because the current code compiles with patching base module. > > On the other hand: it just works! 😉 > > Yeah, this is a bit of a hack!. It would be better to separate these out, but then what would we do, still patch it into java.base or build a slim module around it or something? It doesn't feel any better than just patching it all into java.base! Let's keep it as is. The whole compile is a hack, modules do not matter. With separate apijar we could also add it to classpath as the package names are not special at all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
