ChrisHegarty commented on code in PR #12311:
URL: https://github.com/apache/lucene/pull/12311#discussion_r1198703579
##########
gradle/testing/defaults-tests.gradle:
##########
@@ -122,7 +122,7 @@ allprojects {
// Lucene needs to optional modules at runtime, which we want to enforce
for testing
// (if the runner JVM does not support them, it will fail tests):
- jvmArgs '--add-modules', 'jdk.unsupported,jdk.management'
+ jvmArgs '--add-modules',
'jdk.unsupported,jdk.management,jdk.incubator.vector'
Review Comment:
We're going to need a way to test both the default and the VectorAPI
implementations. Currently the code just checks for the presence of the
jdk.incubator.vector module. Either we add some additional configuration, like
say a system prop to forcibly disable the VectorAPI implementation, or else we
could have some gradle-foo that controls the addition of the module in
`--add-modules` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
