uschindler commented on PR #12290: URL: https://github.com/apache/lucene/pull/12290#issuecomment-1549844375
The whole `ByteBufferGuard` does not help too much to prevent code from failing and crushing the VM! But yes, it's a good idea to enforce more. I played with that in the past: `ByteBufferGuard` never helped much, a `full fence` neither. This class was bullshit from the beginning as it only delayed the crushing of JVM a bit more on misuse. So it should never have existed... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
