JarvisCraft commented on code in PR #12290:
URL: https://github.com/apache/lucene/pull/12290#discussion_r1195269692
##########
lucene/core/src/java/org/apache/lucene/store/ByteBufferGuard.java:
##########
@@ -39,7 +40,7 @@ final class ByteBufferGuard {
* this to allow unmapping of bytebuffers with private Java APIs.
*/
@FunctionalInterface
- static interface BufferCleaner {
+ interface BufferCleaner {
Review Comment:
Rolled back, although I feel like `static` does not add to expliicitness
here considering that interfaces never can be non-static; also, most code seems
to omit `static` on inner `interface`s: 23 without it VS 4 with it (including
this one).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
