JarvisCraft opened a new pull request, #12290: URL: https://github.com/apache/lucene/pull/12290
### Description Current implementation of `ByteBufferGuard` uses an implementation-based assumption that `AtomicInteger#lazySet` causes full-barrrier (ie `[prior stores] happen before [following loads & stores]` is required). Since `VarHandle` appearance there have been explicit methods for performing memory fences including full fence thus it seems reasonable to rely on them rather than ungaranteed semantic. It's worth mentioning that unlike #9824 which proposes to use new explicit access modes on the field, this does not change the type of `invalidated` or its access methods but simply replaces the old non-obviously invoked barrier with an obvious one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
