msokolov commented on PR #12248: URL: https://github.com/apache/lucene/pull/12248#issuecomment-1529091242
> I've added the types in, but I'd like to push back a bit on requiring Locale for string.formatted in test code -- the alternative isn't really using Locale and localizing the assertion messages, the realistic alternative is doing old school string concatenation with +, and that's just worse all around. I don't understand - can't we use `String.format(Locale, String ...)` ? This isn't about localization, it's about using a consistent Locale for string formatting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
