msokolov commented on code in PR #12248:
URL: https://github.com/apache/lucene/pull/12248#discussion_r1181269633


##########
lucene/core/src/java/org/apache/lucene/util/hnsw/OnHeapHnswGraph.java:
##########
@@ -204,4 +205,10 @@ public long ramBytesUsed() {
     }
     return total;
   }
+
+  @Override
+  public String toString() {
+    return "OnHeapHnswGraph(size=%d, numLevels=%d, entryNode=%d)"
+        .formatted(size(), numLevels, entryNode);

Review Comment:
   you'll see that the precommit check is failing due to this method being 
forbidden. The reason for this is that behaviors can subtly change when the 
Locale, which is an environmental setting outside the control of the API, is 
changed. We want the library to behave consistently no matter which Locale is 
set, so for that reason we enforce specifying the Locale in string-handling 
functions that are locale-sensitive. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to