msokolov commented on code in PR #12248: URL: https://github.com/apache/lucene/pull/12248#discussion_r1180802698
########## lucene/core/src/test/org/apache/lucene/util/hnsw/HnswGraphTestCase.java: ########## @@ -23,15 +23,7 @@ import com.carrotsearch.randomizedtesting.RandomizedTest; import java.io.IOException; -import java.util.ArrayList; -import java.util.Arrays; -import java.util.Collections; -import java.util.HashMap; -import java.util.HashSet; -import java.util.List; -import java.util.Map; -import java.util.Random; -import java.util.Set; +import java.util.*; Review Comment: I see - I think it would be good to report timings for a pure indexing use case. While it is true that HNSW indexing uses search, so the results are probably predictive, we don't really care much about search performance (outside of indexing) with the on-heap implementation since user searches are conducted using the off-heap graph. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
