zacharymorn commented on code in PR #12194:
URL: https://github.com/apache/lucene/pull/12194#discussion_r1130593481
##########
lucene/core/src/java/org/apache/lucene/search/DocIdSetIterator.java:
##########
@@ -82,6 +82,11 @@ public int advance(int target) throws IOException {
return doc;
}
+ @Override
+ public int peekNextNonMatchingDocID() {
+ return NO_MORE_DOCS;
Review Comment:
Updated.
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.java:
##########
@@ -414,6 +416,13 @@ public int nextDoc() throws IOException {
return advance(doc + 1);
}
+ @Override
+ public int peekNextNonMatchingDocID() {
+ // TODO not exercised by wikimedium10m benchmark
+ // all docs contain values
+ return NO_MORE_DOCS;
Review Comment:
Updated.
##########
lucene/core/src/java/org/apache/lucene/util/BitSetIterator.java:
##########
@@ -92,6 +93,20 @@ public int advance(int target) {
return doc = bits.nextSetBit(target);
}
+ @Override
+ public int peekNextNonMatchingDocID() {
+ // TODO not exercised by wikimedium10m benchmark
+ if (doc == NO_MORE_DOCS || doc + 1 >= length) {
+ return nextNonMatchingDoc = NO_MORE_DOCS;
Review Comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
