rmuir commented on PR #12135: URL: https://github.com/apache/lucene/pull/12135#issuecomment-1425757874
> Another problem I see is the following: The current code uses IndexOrDocvaluesQuery. This creates both queries and there is the stupid part: We sort the terms and popuplate PrefixCodedTerms, although it might no even use the query at execution time at all. This is in my opinion the main issue, not the sorting alone. I see this as a feature, not a bug. As you can see, left unchecked, "database functionality" can be quite invasive on the codebase. There are all these possibilities for this "join" query: * Terms * DV * Points * Terms + DV * Points + DV I think it is the correct tradeoff to just have 3 simple queries, one for each underlying index structure, and use IndexOrDocValues to combine them. It keeps this functionality maintainable and in check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
