rmuir commented on PR #12135: URL: https://github.com/apache/lucene/pull/12135#issuecomment-1425676474
> I disagree with Robert who says "only arrays". I agree with you we can also allow to pass collections. But only when we do it as proposed before: Well, the `newSetQuery()` takes an array, so i don't like adding also collections also, unnecessarily. But especially i don't like complexity added with collections into `PrefixCodedTerms` which has nothing to do with arrays nor collections at all and is just a little part of the indexer becoming made more complicated by these horrible database-join-queries :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
