rmuir commented on PR #12135: URL: https://github.com/apache/lucene/pull/12135#issuecomment-1425690083
> Yes, a public constructor that requires sorted data should check it. The current proposal is doing this by leveraging the class type of the collection. To me this is an AWFUL lot of complexity. Yes, you are just "marking" something as sorted, but java collections are just as bad to me as java streams are to adrien. Please, lets keep such stuff away from PrefixCodedTerms and the indexer. If we can't implement TermInSetQuery without mucking up the indexer here, then maybe indeed we should just tell such database-abusers to use BooleanQuery instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
