rmuir commented on PR #11987: URL: https://github.com/apache/lucene/pull/11987#issuecomment-1335391991
> I think I had not merged it because the follow-up discussion about removing thread locals had triggered naming/API concerns, but it should be a good incremental step and we could figure a way to remove threadlocals in Lucene 10 since it will require API changes? I don't think so, i tend to lean towards Uwe's thoughts here. I feel like this is "rush in another fix for 10,000 shards". We can investigate removing the threadlocals in lucene 10. Very possibly the change could be backported with deprecations for `IR.document(int)` (e.g. which would use threadlocal like now). At least to me, that's the ideal scenario. So you could migrate your lucene 9 code to no longer use deprecated methods and not have the threadlocals. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
