rmuir commented on PR #11987: URL: https://github.com/apache/lucene/pull/11987#issuecomment-1336397936
The threadlocals (closeable or not, i want them out here) only exist because the api is dumb and stateless: `indexreader.document(i)`. So there's no place to store any state to reuse across multiple documents. hence threadlocal is used to workaround a problematic API. i propose we fix the api, then no threadlocal is needed anymore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org