rmuir commented on PR #11971: URL: https://github.com/apache/lucene/pull/11971#issuecomment-1326503365
i'm happy if we disable more of the currently-enabled checks in followup issues. It starts to become subjective, but honestly most of the checks we have enabled are useless. If we haven't done explicit work to fix the associated problems across our (large) codebase, then such static analysis checks probably aren't doing anything. As a next step I'd rather work on enabling some of the checks marked `TODO: there are problems` here. Those are ones that I tried out, and the failures look like possibly real bugs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org