rmuir commented on PR #11955: URL: https://github.com/apache/lucene/pull/11955#issuecomment-1321193321
and i don't mind doing the work here on the testing honestly. or we can do it in another PR. basically I think we should engage the BaseAnalysisFactoryTestCase with simple basic tests like the other factories have. that's a start. today the factories are not really tested directly. Usually its best to at least check different arguments/parameters and exceptional cases, e.g. https://github.com/apache/lucene/blob/main/lucene/analysis/common/src/test/org/apache/lucene/analysis/miscellaneous/TestLimitTokenOffsetFilterFactory.java then we can look at if base test class needs any beefing up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
