rmuir commented on PR #11955: URL: https://github.com/apache/lucene/pull/11955#issuecomment-1321167684
> Does this library also check for race conditions that can arise between ResourceLoaderAware::inform vs TokenStream creation and processing? I know it may be out of the scope of this change but I would be curious to know.. Open NLP has these heavy-weight global resources and I am worried as to how they get initialized. There is an intractable amount code paths to analyze once you take into account all of the configuration possibilities of OpenNLP which seems to be partially based on the binary model file you provide. You can see the code here to the current checker: https://github.com/apache/lucene/blob/main/lucene/test-framework/src/java/org/apache/lucene/tests/analysis/BaseTokenStreamTestCase.java#L949-L951 Basically, we analyze content single-threaded and then spin up threads with a "starting gun" and ensure they create the same result as the single-thread to discover races. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
