rmuir commented on PR #11955: URL: https://github.com/apache/lucene/pull/11955#issuecomment-1321166306
I think there is no contention today due to the way the factories work. There is only one thread/tokenstream for *Op. But I am happy to add the random tests and remove the code smell? It may also confuse profilers which is what is really needed here to see where the performance issues are. Some things in opennlp are definitely hurting performance, such as only supporting String in their apis. This will create gazillions of objects. But I doubt it's the biggest issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
