uschindler commented on PR #11840: URL: https://github.com/apache/lucene/pull/11840#issuecomment-1279955134
> It seems to me it is a tool detecting whether there's difference in implementation, but still we are not able to avoid losing IndexSearcher once we've called a delegated method? Yes, basically all classes that delegate rewrite to downstream classes need to change to new API, so we still need to backport everything to 9.x and only detect cases where somebody uses the *old* api. Of course in the case that somebody writes a subclass that only implements the IndexReaer variant of rewrite you use the searcher. If this code then rewrites subqueries on its own it will call "rewrite(IndexReader)" and so it is subqueries won't use parallelization. This is not so dramatic as a new query in user's code will just never pass parallelization down its subqueries. Let me think a few evening about it :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
