jpountz commented on code in PR #11840:
URL: https://github.com/apache/lucene/pull/11840#discussion_r994219709
##########
lucene/core/src/java/org/apache/lucene/search/FieldExistsQuery.java:
##########
@@ -18,16 +18,7 @@
import java.io.IOException;
import java.util.Objects;
-import org.apache.lucene.index.DocValues;
-import org.apache.lucene.index.DocValuesType;
-import org.apache.lucene.index.FieldInfo;
-import org.apache.lucene.index.FieldInfos;
-import org.apache.lucene.index.IndexOptions;
-import org.apache.lucene.index.IndexReader;
-import org.apache.lucene.index.LeafReader;
-import org.apache.lucene.index.LeafReaderContext;
-import org.apache.lucene.index.PointValues;
-import org.apache.lucene.index.Terms;
+import org.apache.lucene.index.*;
Review Comment:
Can you undo the star import?
##########
lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java:
##########
@@ -86,12 +86,12 @@ public KnnVectorQuery(String field, float[] target, int k,
Query filter) {
}
@Override
- public Query rewrite(IndexReader reader) throws IOException {
+ public Query rewrite(IndexSearcher indexSearcher) throws IOException {
+ IndexReader reader = indexSearcher.getIndexReader();
TopDocs[] perLeafResults = new TopDocs[reader.leaves().size()];
Weight filterWeight = null;
if (filter != null) {
- IndexSearcher indexSearcher = new IndexSearcher(reader);
Review Comment:
Being able to undo this is good. :+1:
##########
lucene/highlighter/src/java/org/apache/lucene/search/vectorhighlight/FieldQuery.java:
##########
@@ -28,16 +28,7 @@
import org.apache.lucene.index.IndexReader;
import org.apache.lucene.index.Term;
import org.apache.lucene.queries.function.FunctionScoreQuery;
-import org.apache.lucene.search.BooleanClause;
-import org.apache.lucene.search.BooleanQuery;
-import org.apache.lucene.search.BoostQuery;
-import org.apache.lucene.search.ConstantScoreQuery;
-import org.apache.lucene.search.DisjunctionMaxQuery;
-import org.apache.lucene.search.MultiTermQuery;
-import org.apache.lucene.search.PhraseQuery;
-import org.apache.lucene.search.Query;
-import org.apache.lucene.search.SynonymQuery;
-import org.apache.lucene.search.TermQuery;
+import org.apache.lucene.search.*;
Review Comment:
undo?
##########
lucene/highlighter/src/test/org/apache/lucene/search/highlight/custom/TestHighlightCustomQuery.java:
##########
@@ -21,12 +21,8 @@
import java.util.Map;
import java.util.Objects;
import org.apache.lucene.analysis.TokenStream;
-import org.apache.lucene.index.IndexReader;
import org.apache.lucene.index.Term;
-import org.apache.lucene.search.BoostQuery;
-import org.apache.lucene.search.Query;
-import org.apache.lucene.search.QueryVisitor;
-import org.apache.lucene.search.TermQuery;
+import org.apache.lucene.search.*;
Review Comment:
undo?
##########
lucene/sandbox/src/java/org/apache/lucene/sandbox/queries/FuzzyLikeThisQuery.java:
##########
@@ -32,15 +32,7 @@
import org.apache.lucene.index.TermStates;
import org.apache.lucene.index.Terms;
import org.apache.lucene.index.TermsEnum;
-import org.apache.lucene.search.BooleanClause;
-import org.apache.lucene.search.BooleanQuery;
-import org.apache.lucene.search.BoostAttribute;
-import org.apache.lucene.search.BoostQuery;
-import org.apache.lucene.search.ConstantScoreQuery;
-import org.apache.lucene.search.FuzzyTermsEnum;
-import org.apache.lucene.search.Query;
-import org.apache.lucene.search.QueryVisitor;
-import org.apache.lucene.search.TermQuery;
+import org.apache.lucene.search.*;
Review Comment:
undo?
##########
lucene/facet/src/java/org/apache/lucene/facet/DrillDownQuery.java:
##########
@@ -24,15 +24,9 @@
import java.util.Map;
import java.util.Objects;
import java.util.Set;
-import org.apache.lucene.index.IndexReader;
import org.apache.lucene.index.Term;
+import org.apache.lucene.search.*;
Review Comment:
undo the start import?
##########
lucene/queries/src/java/org/apache/lucene/queries/mlt/MoreLikeThisQuery.java:
##########
@@ -22,11 +22,7 @@
import java.util.Objects;
import java.util.Set;
import org.apache.lucene.analysis.Analyzer;
-import org.apache.lucene.index.IndexReader;
-import org.apache.lucene.search.BooleanClause;
-import org.apache.lucene.search.BooleanQuery;
-import org.apache.lucene.search.Query;
-import org.apache.lucene.search.QueryVisitor;
+import org.apache.lucene.search.*;
Review Comment:
undo?
##########
lucene/core/src/java/org/apache/lucene/document/FeatureQuery.java:
##########
@@ -50,12 +49,12 @@ final class FeatureQuery extends Query {
}
@Override
- public Query rewrite(IndexReader reader) throws IOException {
- FeatureFunction rewritten = function.rewrite(reader);
+ public Query rewrite(IndexSearcher indexSearcher) throws IOException {
+ FeatureFunction rewritten =
function.rewrite(indexSearcher.getIndexReader());
Review Comment:
maybe change the signature of `FeatureFunction#rewrite` to take an
`IndexSearcher` as well for consistency?
##########
lucene/highlighter/src/test/org/apache/lucene/search/vectorhighlight/TestFieldQuery.java:
##########
@@ -23,17 +23,8 @@
import java.util.Map;
import java.util.Set;
import org.apache.lucene.index.Term;
+import org.apache.lucene.search.*;
Review Comment:
undo?
##########
lucene/queries/src/java/org/apache/lucene/queries/CommonTermsQuery.java:
##########
@@ -27,13 +27,8 @@
import org.apache.lucene.index.TermStates;
import org.apache.lucene.index.Terms;
import org.apache.lucene.index.TermsEnum;
+import org.apache.lucene.search.*;
Review Comment:
undo?
##########
lucene/queryparser/src/java/org/apache/lucene/queryparser/surround/query/SimpleTermRewriteQuery.java:
##########
@@ -19,12 +19,8 @@
import java.io.IOException;
import java.util.ArrayList;
import java.util.List;
-import org.apache.lucene.index.IndexReader;
import org.apache.lucene.index.Term;
-import org.apache.lucene.search.BooleanClause;
-import org.apache.lucene.search.MatchNoDocsQuery;
-import org.apache.lucene.search.Query;
-import org.apache.lucene.search.QueryVisitor;
+import org.apache.lucene.search.*;
Review Comment:
undo?
##########
lucene/classification/src/java/org/apache/lucene/classification/utils/NearestFuzzyQuery.java:
##########
@@ -31,13 +31,7 @@
import org.apache.lucene.index.TermStates;
import org.apache.lucene.index.Terms;
import org.apache.lucene.index.TermsEnum;
-import org.apache.lucene.search.BooleanClause;
-import org.apache.lucene.search.BooleanQuery;
-import org.apache.lucene.search.BoostQuery;
-import org.apache.lucene.search.FuzzyTermsEnum;
-import org.apache.lucene.search.Query;
-import org.apache.lucene.search.QueryVisitor;
-import org.apache.lucene.search.TermQuery;
+import org.apache.lucene.search.*;
Review Comment:
Can you undo the wildcard import?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
