zhaih commented on PR #11840: URL: https://github.com/apache/lucene/pull/11840#issuecomment-1279787336
I tried created one but then realized it seems not working, because query rewriting are rewriting query from top of the tree to the bottom so once we delegate to `rewrite(IndexReader)` we're not able to call the indexSearcher one in the children. I wonder if people are ok with this only happens after Lucene 10? Or @uschindler can you help evaluate using `VirtualMethod`? It seems to me it is a tool detecting whether there's difference in implementation, but still we are not able to avoid losing IndexSearcher once we've called a delegated method? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
