stefanvodita commented on PR #11780: URL: https://github.com/apache/lucene/pull/11780#issuecomment-1269159465
Thinking some more about this change in light of the comments, I see 3 ways it could go: 1. Do nothing. The user can already instantiate new reader states after a refresh if they want. No new API is required. 2. What this PR tried - offer an API to refresh and compute new reader states as one operation. @mikemccand points out this is likely not useful. 3. Allow the user to update the ordinal maps in the reader states they already have without requiring them to completely recreate the reader states. I’m not sure how much this accomplishes. The Javadoc suggests that the bulk of the work in instantiating a SortedSetDocValuesReaderState is building the ordinal map. In that case, updating the ordinal maps instead of recreating the reader states doesn’t have much benefit. Do any of these seem like reasonable approaches to address the original issue? If not, how else could we approach this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
