shaie commented on code in PR #11764:
URL: https://github.com/apache/lucene/pull/11764#discussion_r969152978
##########
lucene/facet/src/java/org/apache/lucene/facet/facetset/MatchingFacetSetsCounts.java:
##########
@@ -156,7 +157,43 @@ public FacetResult getAllChildren(String dim, String...
path) throws IOException
@Override
public FacetResult getTopChildren(int topN, String dim, String... path)
throws IOException {
validateTopN(topN);
- return getAllChildren(dim, path);
+
+ topN = Math.min(topN, counts.length);
+
+ PriorityQueue<Entry> pq =
+ new PriorityQueue<>(topN) {
+ @Override
+ protected boolean lessThan(Entry a, Entry b) {
+ int cmp = Integer.compare(a.count, b.count);
+ if (cmp == 0) {
+ cmp = b.label.compareTo(a.label);
+ }
+ return cmp < 0;
+ }
+ };
+
+ int childCount = 0;
+ Entry reuse = null;
+ for (int i = 0; i < counts.length; i++) {
+ int count = counts[i];
+ if (count > 0) {
+ childCount++;
+ if (reuse == null) {
+ reuse = new Entry();
+ }
+ reuse.label = facetSetMatchers[i].label;
+ reuse.count = count;
+ reuse = pq.insertWithOverflow(reuse);
+ }
+ }
+
+ LabelAndValue[] labelValues = new LabelAndValue[topN];
+ for (int i = topN - 1; i >= 0; i--) {
+ Entry e = pq.pop();
Review Comment:
Right, I meant `continue` :). I forgot that the sentinel values are "on
top". And yes, `pop()` all the sentinel values before we populate the array is
the way to get rid of them.
##########
lucene/facet/src/java/org/apache/lucene/facet/facetset/MatchingFacetSetsCounts.java:
##########
@@ -156,7 +157,46 @@ public FacetResult getAllChildren(String dim, String...
path) throws IOException
@Override
public FacetResult getTopChildren(int topN, String dim, String... path)
throws IOException {
validateTopN(topN);
- return getAllChildren(dim, path);
+
+ topN = Math.min(topN, counts.length);
+
+ PriorityQueue<Entry> pq =
+ new PriorityQueue<>(topN, () -> new Entry("", 0)) {
+ @Override
+ protected boolean lessThan(Entry a, Entry b) {
+ return compare(a.count, b.count, a.label, b.label) < 0;
+ }
+ };
+
+ int childCount = 0;
+ Entry reuse = pq.top();
+ for (int i = 0; i < counts.length; i++) {
+ int count = counts[i];
+ if (count > 0) {
+ childCount++;
+ String label = facetSetMatchers[i].label;
+ if (compare(reuse.count, count, reuse.label, label) < 0) {
+ reuse.label = label;
+ reuse.count = count;
+ reuse = pq.updateTop();
+ }
+ }
+ }
+
+ // Pop off any sentinel values in the case that we had fewer child labels
with non-zero
+ // counts than the requested top-n:
+ while (childCount < pq.size()) {
+ pq.pop();
+ }
+
+ LabelAndValue[] labelValues = new LabelAndValue[Math.min(topN,
childCount)];
+ for (int i = pq.size() - 1; i >= 0; i--) {
+ Entry e = pq.pop();
+ assert e != null;
Review Comment:
nit: I don't think this assertion contributes much because if it's `null`
we'll fail in the next line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
