gsmiller commented on code in PR #11764:
URL: https://github.com/apache/lucene/pull/11764#discussion_r968941406
##########
lucene/facet/src/java/org/apache/lucene/facet/facetset/MatchingFacetSetsCounts.java:
##########
@@ -156,7 +157,43 @@ public FacetResult getAllChildren(String dim, String...
path) throws IOException
@Override
public FacetResult getTopChildren(int topN, String dim, String... path)
throws IOException {
validateTopN(topN);
- return getAllChildren(dim, path);
+
+ topN = Math.min(topN, counts.length);
+
+ PriorityQueue<Entry> pq =
+ new PriorityQueue<>(topN) {
+ @Override
+ protected boolean lessThan(Entry a, Entry b) {
+ int cmp = Integer.compare(a.count, b.count);
+ if (cmp == 0) {
+ cmp = b.label.compareTo(a.label);
+ }
+ return cmp < 0;
+ }
+ };
+
+ int childCount = 0;
+ Entry reuse = null;
+ for (int i = 0; i < counts.length; i++) {
+ int count = counts[i];
+ if (count > 0) {
+ childCount++;
+ if (reuse == null) {
+ reuse = new Entry();
+ }
+ reuse.label = facetSetMatchers[i].label;
+ reuse.count = count;
+ reuse = pq.insertWithOverflow(reuse);
+ }
+ }
+
+ LabelAndValue[] labelValues = new LabelAndValue[topN];
+ for (int i = topN - 1; i >= 0; i--) {
+ Entry e = pq.pop();
Review Comment:
Ah, never mind on the NPE concern. Since we rely on PQ#size as a bound (and
since we don't use sentinel values in the other implementations), we're safe
there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
