gsmiller commented on code in PR #11764:
URL: https://github.com/apache/lucene/pull/11764#discussion_r968922810
##########
lucene/facet/src/java/org/apache/lucene/facet/facetset/MatchingFacetSetsCounts.java:
##########
@@ -156,7 +157,43 @@ public FacetResult getAllChildren(String dim, String...
path) throws IOException
@Override
public FacetResult getTopChildren(int topN, String dim, String... path)
throws IOException {
validateTopN(topN);
- return getAllChildren(dim, path);
+
+ topN = Math.min(topN, counts.length);
+
+ PriorityQueue<Entry> pq =
+ new PriorityQueue<>(topN) {
+ @Override
+ protected boolean lessThan(Entry a, Entry b) {
+ int cmp = Integer.compare(a.count, b.count);
+ if (cmp == 0) {
+ cmp = b.label.compareTo(a.label);
+ }
+ return cmp < 0;
+ }
+ };
+
+ int childCount = 0;
+ Entry reuse = null;
+ for (int i = 0; i < counts.length; i++) {
+ int count = counts[i];
+ if (count > 0) {
+ childCount++;
+ if (reuse == null) {
+ reuse = new Entry();
+ }
+ reuse.label = facetSetMatchers[i].label;
+ reuse.count = count;
+ reuse = pq.insertWithOverflow(reuse);
+ }
+ }
+
+ LabelAndValue[] labelValues = new LabelAndValue[topN];
+ for (int i = topN - 1; i >= 0; i--) {
+ Entry e = pq.pop();
Review Comment:
I think we'd actually need to `continue` the loop while we have sentinel
values on top right? Not `break`? Then we'd actually need to truncate those
sentinel values off the final array? This actually makes me wonder if we don't
have a pre-existing bug in our other faceting implementations in the case that
we have fewer non-zero counts than requested top-n (but in that case I think
we'd NPE). Hmm...
##########
lucene/facet/src/test/org/apache/lucene/facet/facetset/TestExactFacetSetMatcher.java:
##########
@@ -46,6 +49,105 @@ public class TestExactFacetSetMatcher extends FacetTestCase
{
private static final int[] MANUFACTURER_ORDS = {FORD_ORD, TOYOTA_ORD,
CHEVY_ORD, NISSAN_ORD};
private static final int[] YEARS = {2010, 2011, 2012};
+ public void testTopChildren() throws Exception {
Review Comment:
Sure, makes sense to me. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
