tang-hi commented on PR #1016: URL: https://github.com/apache/lucene/pull/1016#issuecomment-1198427351
> > Depends on how you look at it - all the generators are there (along with the resources they use). Previously they lived together with the sources (and required manual exclusions to not end up in the final classes/ jars). One way to clean it up would be to move the generated code (java sources) to not live together with the rest of java code - these should really be moved elsewhere (to a different source set). It would require shuffling things around a bit, including various build pieces. > > @dweiss Sorry if my feedback wasn't constructive. I think the situation is just a bit confusing if you look at the python sources: > > ``` > $ find . -name "*.py" > ./dev-tools/scripts/releasedJirasRegex.py > ./dev-tools/scripts/smokeTestRelease.py > ./dev-tools/scripts/scriptutil.py > ./dev-tools/scripts/addBackcompatIndexes.py > ./dev-tools/scripts/addVersion.py > ./dev-tools/scripts/create_line_file_docs.py > ./dev-tools/scripts/buildAndPushRelease.py > ./dev-tools/scripts/releaseWizard.py > ./dev-tools/scripts/githubPRs.py > ./dev-tools/scripts/reproduceJenkinsFailures.py > ./lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene84/gen_ForUtil.py > ./lucene/core/build/classes/java/test/org/apache/lucene/util/makeEuroparlLineFile.py > ./lucene/core/src/java/org/apache/lucene/util/packed/gen_BulkOperation.py > ./lucene/core/src/java/org/apache/lucene/util/packed/gen_Packed64SingleBlock.py > ./lucene/core/src/java/org/apache/lucene/util/automaton/UTF32ToUTF8.py > ./lucene/core/src/java/org/apache/lucene/codecs/lucene90/gen_ForUtil.py > ./lucene/core/src/test/org/apache/lucene/util/makeEuroparlLineFile.py > ./gradle/generation/jflex/htmlentity.py > ./gradle/generation/moman/gen_BulkOperation.py > ./gradle/generation/moman/gen_Packed64SingleBlock.py > ./gradle/generation/moman/createLevAutomata.py > ./gradle/documentation/check-broken-links/checkJavadocLinks.py > ``` > > Note how there is both `./lucene/core/src/java/org/apache/lucene/util/packed/gen_BulkOperation.py` and `./gradle/generation/moman/gen_BulkOperation.py`. Same with `gen_Packed64SingleBlock`. Then we have a `gen_ForUtil.py` that looks like a generator but only exists in the main sources. > > So I'm just a bit confused. If all the python generation code was in `./gradle/generation`, no duplicate files, etc, then I would be a lot less confused. > > Separately, as far as making it easier to work with, I think an easy win is for generated `LevXXXParametricDescription.java` files to have a little bit better comment, e.g. pointing to the location of python code that generated them. We just have to do a simple tweak to the python code for that. I think pointing to the location of python code that generated them is a good idea, I will try to figure out createLevAutomata.py and add the comment in it tomorrow -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
