LuXugang commented on PR #967: URL: https://github.com/apache/lucene/pull/967#issuecomment-1160497729
> Thanks for catching this bug. The fix is a bit wasteful in that it requires iterating over ords twice, once to count them and another time to iterate through them. Maybe we should change `DocOrds` to also record the number of ords for each doc (e.g. using a `GrowableWriter`), and stop recording zeroes to signal that all ords for a document have been consumed? Thanks for your suggestion, @jpountz . Remove the sentinel value zero and use GrowableWriter could make code more readable! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
