gsmiller commented on code in PR #922:
URL: https://github.com/apache/lucene/pull/922#discussion_r893860958
##########
lucene/facet/src/java/org/apache/lucene/facet/FacetField.java:
##########
@@ -30,14 +30,12 @@
*/
public class FacetField extends Field {
- /** Field type used for storing facet values: docs, freqs, and positions. */
+ /**
+ * Field type used for storing facet values. Actual field type used for
indexing is determined in
+ * {@link FacetsConfig#build(TaxonomyWriter, Document)}
+ */
public static final FieldType TYPE = new FieldType();
- static {
Review Comment:
I think it's reasonable to remove this to avoid potential future confusion
(like what arose in this PR initially). I did some code searching and can't
find anywhere that `FacetField` is used outside of `FacetsConfig`, and the
change looks like a perfectly safe no-op. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
