mikemccand commented on PR #922: URL: https://github.com/apache/lucene/pull/922#issuecomment-1156516445
Yeah I think these attributes of `FacetField.TYPE` are not used, but it is trappy looking. This `TYPE` is really just a marker/singleton so `FacetsConfig.build` can know which fields in the incoming document are `FacetField`. So this is really a "remove dead code that looks like it might still be twitching" sort of situation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
