kaivalnp commented on code in PR #932:
URL: https://github.com/apache/lucene/pull/932#discussion_r908869810
##########
lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java:
##########
@@ -225,6 +225,11 @@ public BitSetIterator getIterator(int contextOrd) {
return new BitSetIterator(bitSets[contextOrd], cost[contextOrd]);
}
+ public void setBitSet(BitSet bitSet, int cost) {
+ bitSets[ord] = bitSet;
Review Comment:
> What would you think of this plan?
>
> * Spin off a separate issue around removing overhead from copying `BitSet`
when the query is cached or precomputed. Maybe we'll end up with something
similar to your change where we access the iterator directly.
> * Either hold off on this PR until that overhead is addressed, or merge it
but without a special workaround to prevent copying. To unblock any testing you
could fork `KnnGraphTester` locally or `KnnVectorQuery` to add a workaround?
Now that the issue for the overhead is addressed, should we look into this
PR again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
