jtibshirani commented on code in PR #932:
URL: https://github.com/apache/lucene/pull/932#discussion_r888247099
##########
lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java:
##########
@@ -225,6 +225,11 @@ public BitSetIterator getIterator(int contextOrd) {
return new BitSetIterator(bitSets[contextOrd], cost[contextOrd]);
}
+ public void setBitSet(BitSet bitSet, int cost) {
+ bitSets[ord] = bitSet;
Review Comment:
I am surprised that iterating and copying the `BitSet` is so expensive --
would you up for sharing some numbers with and without the copying? It might
give ideas for optimizations.
Depending on what exactly you're trying to test, I guess we could go back to
a strategy where you call `LeafReader#searchNearestVectors` directly, with the
filter docs folded into `acceptDocs`? I have the same intuition as @kaivalnp
that it feels funny to be benchmarking a workflow that we don't actually follow
in a production setting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
