jtibshirani commented on code in PR #924: URL: https://github.com/apache/lucene/pull/924#discussion_r885948710
########## lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene92/Lucene92RWHnswVectorsFormat.java: ########## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.lucene.backward_codecs.lucene92; + +import java.io.IOException; +import org.apache.lucene.codecs.KnnVectorsReader; +import org.apache.lucene.codecs.KnnVectorsWriter; +import org.apache.lucene.index.SegmentReadState; +import org.apache.lucene.index.SegmentWriteState; + +public final class Lucene92RWHnswVectorsFormat extends Lucene92HnswVectorsFormat { Review Comment: This still doesn't seem consistent with `Lucene91RWHnswVectorsFormat` and `Lucene90RWHnswVectorsFormat`, which have constructors like this: ``` public Lucene91RWHnswVectorsFormat(int maxConn, int beamWidth) { super(maxConn, beamWidth); } ``` It seems nice to keep the same pattern for all backwards codecs, less mental overhead from wondering why they are subtly different! ########## lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene92/Lucene92HnswVectorsFormat.java: ########## @@ -151,10 +131,6 @@ public KnnVectorsReader fieldsReader(SegmentReadState state) throws IOException @Override public String toString() { - return "lucene92HnswVectorsFormat(name = lucene92HnswVectorsFormat, maxConn = " - + maxConn - + ", beamWidth=" - + beamWidth - + ")"; + return "lucene92HnswVectorsFormat"; Review Comment: It looks like a bug that this wasn't capitalized, maybe we can just fix it here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
