msokolov commented on PR #924: URL: https://github.com/apache/lucene/pull/924#issuecomment-1137306689
Thanks for the reminder about the unit tests - I will add. As for the approach of using a feature branch, I'm ambivalent. It seems better to me to separate out the "new codec version" commit with all of its boilerplate from the actual changes to be made to the codec, to make it easier to review and understand. Certainly that can be done on a feature branch, but I'm not sure why we need a branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
