jtibshirani commented on PR #924: URL: https://github.com/apache/lucene/pull/924#issuecomment-1136525898
I think you may have forgotten to create unit tests for the old format (step 2 here: https://github.com/apache/lucene/tree/main/lucene/backward-codecs#making-index-format-changes). Also, would it make sense to merge this to a feature branch, so you could bundle it with the quantization changes you're planning? We recently took this approach for some other changes to the vectors format like LUCENE-10502. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
