jtibshirani commented on PR #926: URL: https://github.com/apache/lucene/pull/926#issuecomment-1141529401
Thanks @alessandrobenedetti for working on this nice simplification! One thing I wanted to double-check -- for Euclidean distance we're now performing an extra division compared to before. I don't think this will have any significant impact on performance, and shouldn't affect the unrolling optimization added in LUCENE-10453, but I'm not 100% sure 🤔 Our nightly benchmarks only test `VectorSimilarityFunction.DOT_PRODUCT` so we wouldn't be able to catch a difference. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
