alessandrobenedetti commented on code in PR #926:
URL: https://github.com/apache/lucene/pull/926#discussion_r883956265
##########
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphSearcher.java:
##########
@@ -155,14 +155,14 @@ private NeighborQueue searchLevel(
// A bound that holds the minimum similarity to the query vector that a
candidate vector must
// have to be considered.
- BoundsChecker bound = BoundsChecker.create(similarityFunction.reversed);
+ float minAcceptedSimilarity = Float.NEGATIVE_INFINITY;
if (results.size() >= topK) {
- bound.set(results.topScore());
+ minAcceptedSimilarity = results.topNodeScore();
}
while (candidates.size() > 0 && results.incomplete() == false) {
// get the best candidate (closest or best scoring)
- float topCandidateScore = candidates.topScore();
- if (bound.check(topCandidateScore)) {
+ float topCandidateSimilarity = candidates.topNodeScore();
Review Comment:
it is a similarity score rather than a document score(even if they pretty
much align).
Let's decide if naming all of them 'similarity" (as it should be right now)
or all "scores"
I am more in favor of 'similarity' as it makes the code a bit more readable,
not a strong opinion anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
