alessandrobenedetti commented on code in PR #926:
URL: https://github.com/apache/lucene/pull/926#discussion_r884908511
##########
lucene/core/src/test/org/apache/lucene/search/TestKnnVectorQuery.java:
##########
@@ -193,25 +208,40 @@ public void testAdvanceShallow() throws IOException {
}
try (IndexReader reader = DirectoryReader.open(d)) {
IndexSearcher searcher = new IndexSearcher(reader);
- KnnVectorQuery query = new KnnVectorQuery("field", new float[] {2, 3},
3);
+ KnnVectorQuery query = new KnnVectorQuery("field", new float[] {0.5f,
1}, 3);
Review Comment:
I have reverted this and proposed a possible solution.
The node ID and score encoding in the HEAP was broken for such edge cases in
my opinion for the majority of similarity functions.
Euclidean tests were green because of the reverse!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
