iverase commented on pull request #709: URL: https://github.com/apache/lucene/pull/709#issuecomment-1050884300
What I want to make sure is this is covered in the javadocs and we are not relying on an implementation detail. #grow needs to be called with the number of times you are going to be calling BulkAdder#addDoc in order to make sure you don't overflow the sparse data structure. That should be added to the javadocs and maybe avoid the word documents that is causing all the confusion here. We can add that if grow is called with Integer.MAX_VALUE, there are not limit to the calls or something along those lines. wdyt? Finally, we might need to modify the `AssertingLeafReader` as it asserts that you call #grow with the number of points you are going to visit, which in this case is not true all the time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
