rmuir commented on a change in pull request #709:
URL: https://github.com/apache/lucene/pull/709#discussion_r814040808
##########
File path: lucene/core/src/java/org/apache/lucene/util/DocIdSetBuilder.java
##########
@@ -266,20 +224,12 @@ private void upgradeToBitSet() {
public DocIdSet build() {
try {
if (bitSet != null) {
- assert counter >= 0;
- final long cost = Math.round(counter / numValuesPerDoc);
- return new BitDocIdSet(bitSet, cost);
+ return new BitDocIdSet(bitSet);
Review comment:
I don't think it is difficult, it just requires a little work. I can get
to it soon, seems like it should be fun. Ultimately I think it will give us
better estimations than what we have today, without all the tangled APIs and
abstraction leakage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
